Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.22 #13411 +/- ##
============================================
- Coverage 17.67% 17.67% -0.01%
Complexity 15792 15792
============================================
Files 5922 5922
Lines 533167 533178 +11
Branches 65210 65210
============================================
- Hits 94246 94243 -3
- Misses 428276 428288 +12
- Partials 10645 10647 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
|
@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 18243 |
|
Looks good, but I did not test. |
| snapshot.setImageStore(imageStore); | ||
| } catch (CloudRuntimeException ex) { | ||
| logger.error("There was an error while selecting image store for snapshot: {}", ex.getMessage()); | ||
| handleErrorInUncreatedSnapshot(snapshotId); |
There was a problem hiding this comment.
should this also give back the snapshot and storage counts the account was charged? it throws before the catch below that does that, and deleting a snapshot in error doesnt give them back either
This branch has not been deployed
6 participants
Description
If the environment has a malformed (wrong logic, syntax error, etc.) secondary storage selector heuristic rule, an exception is thrown during its interpretation. The snapshot creation process gets the environment's
SNAPSHOTtype secondary storage selectors and interprets its heuristic rule, if any was returned. However, this validation does not handle exceptions thrown by the interpreter.With that, the snapshot record that was created in the
Allocatedstate is never normalized, even though the creation process was finished prematurely due to the interpretation error. Therefore, changes were made to normalize the snapshot state toErrorin these cases.Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
First, I created a malformed secondary storage selector:
Secondary storage selector creation command
create secondarystorageselector name=a description=a type=SNAPSHOT zoneid=a9a3fc15-008f-48b1-8964-d946104b4b17 heuristicrule="if"Then, I tried to create a volume snapshot, and validated that it was set to the
Allocatedstate. After applying the changes, I repeated the process and validated that the snapshot was set to theErrorstate.